[PATCH] D54769: [FileCheck] New option -warn

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

I agree the diagnostic should be an error not a warning when it's enabled.  I meant to be arguing that it should initially be disabled by default so that it's easier for multiple people to help investigate various test suites, but I conflated the two concepts.

We could have something like -diag=[no-]DIAG where DIAG is something like unused-prefix (this patch) or label-only (the other patch) or whatever.  At first, for each DIAG value, the default would be off, -diag=DIAG could be specified in FILECHECK_OPTS, and -diag=no-DIAG could be added to specific tests that will never be adjusted (keep in mind that the command line has higher precedence than FILECHECK_OPTS).  Later, when we're more confident, the default would be on.  If we eventually decide the diagnostic is always right and that -diag=no-DIAG thus should never be used, then we disable that option.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54769/new/

https://reviews.llvm.org/D54769