[lld] r347621 - [WebAssembly] Remove `using` statements from header files. NFC.
Sam Clegg via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 26 17:08:16 PST 2018
Author: sbc
Date: Mon Nov 26 17:08:16 2018
New Revision: 347621
URL: http://llvm.org/viewvc/llvm-project?rev=347621&view=rev
Log:
[WebAssembly] Remove `using` statements from header files. NFC.
Differential Revision: https://reviews.llvm.org/D54758
Modified:
lld/trunk/include/lld/Common/LLVM.h
lld/trunk/wasm/Driver.cpp
lld/trunk/wasm/InputChunks.h
lld/trunk/wasm/InputFiles.h
lld/trunk/wasm/InputGlobal.h
lld/trunk/wasm/OutputSections.h
lld/trunk/wasm/SymbolTable.cpp
lld/trunk/wasm/SymbolTable.h
lld/trunk/wasm/Symbols.h
lld/trunk/wasm/WriterUtils.h
Modified: lld/trunk/include/lld/Common/LLVM.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Common/LLVM.h?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/include/lld/Common/LLVM.h (original)
+++ lld/trunk/include/lld/Common/LLVM.h Mon Nov 26 17:08:16 2018
@@ -44,6 +44,21 @@ namespace llvm {
class raw_ostream;
// TODO: DenseMap, ...
+
+ namespace object {
+ class WasmObjectFile;
+ struct WasmSection;
+ struct WasmSegment;
+ class WasmSymbol;
+ }
+
+ namespace wasm {
+ struct WasmFunction;
+ struct WasmGlobal;
+ struct WasmGlobalType;
+ struct WasmRelocation;
+ struct WasmSignature;
+ }
}
namespace lld {
@@ -69,6 +84,16 @@ namespace lld {
using llvm::Expected;
using llvm::raw_ostream;
+
+ using llvm::object::WasmObjectFile;
+ using llvm::object::WasmSection;
+ using llvm::object::WasmSegment;
+ using llvm::object::WasmSymbol;
+ using llvm::wasm::WasmFunction;
+ using llvm::wasm::WasmGlobal;
+ using llvm::wasm::WasmGlobalType;
+ using llvm::wasm::WasmRelocation;
+ using llvm::wasm::WasmSignature;
} // end namespace lld.
namespace std {
Modified: lld/trunk/wasm/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/Driver.cpp?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/wasm/Driver.cpp (original)
+++ lld/trunk/wasm/Driver.cpp Mon Nov 26 17:08:16 2018
@@ -31,6 +31,7 @@
#define DEBUG_TYPE "lld"
using namespace llvm;
+using namespace llvm::object;
using namespace llvm::sys;
using namespace llvm::wasm;
Modified: lld/trunk/wasm/InputChunks.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/InputChunks.h?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/wasm/InputChunks.h (original)
+++ lld/trunk/wasm/InputChunks.h Mon Nov 26 17:08:16 2018
@@ -24,18 +24,9 @@
#include "Config.h"
#include "InputFiles.h"
#include "lld/Common/ErrorHandler.h"
+#include "lld/Common/LLVM.h"
#include "llvm/Object/Wasm.h"
-using llvm::object::WasmSection;
-using llvm::object::WasmSegment;
-using llvm::wasm::WasmFunction;
-using llvm::wasm::WasmRelocation;
-using llvm::wasm::WasmSignature;
-
-namespace llvm {
-class raw_ostream;
-}
-
namespace lld {
namespace wasm {
Modified: lld/trunk/wasm/InputFiles.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/InputFiles.h?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/wasm/InputFiles.h (original)
+++ lld/trunk/wasm/InputFiles.h Mon Nov 26 17:08:16 2018
@@ -20,18 +20,6 @@
#include "llvm/Support/MemoryBuffer.h"
#include <vector>
-using llvm::object::Archive;
-using llvm::object::WasmObjectFile;
-using llvm::object::WasmSection;
-using llvm::object::WasmSymbol;
-using llvm::wasm::WasmRelocation;
-
-namespace llvm {
-namespace lto {
-class InputFile;
-}
-} // namespace llvm
-
namespace lld {
namespace wasm {
@@ -81,12 +69,12 @@ public:
explicit ArchiveFile(MemoryBufferRef M) : InputFile(ArchiveKind, M) {}
static bool classof(const InputFile *F) { return F->kind() == ArchiveKind; }
- void addMember(const Archive::Symbol *Sym);
+ void addMember(const llvm::object::Archive::Symbol *Sym);
void parse() override;
private:
- std::unique_ptr<Archive> File;
+ std::unique_ptr<llvm::object::Archive> File;
llvm::DenseSet<uint64_t> Seen;
};
Modified: lld/trunk/wasm/InputGlobal.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/InputGlobal.h?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/wasm/InputGlobal.h (original)
+++ lld/trunk/wasm/InputGlobal.h Mon Nov 26 17:08:16 2018
@@ -16,8 +16,6 @@
#include "lld/Common/ErrorHandler.h"
#include "llvm/Object/Wasm.h"
-using llvm::wasm::WasmGlobal;
-
namespace lld {
namespace wasm {
Modified: lld/trunk/wasm/OutputSections.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/OutputSections.h?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/wasm/OutputSections.h (original)
+++ lld/trunk/wasm/OutputSections.h Mon Nov 26 17:08:16 2018
@@ -13,11 +13,9 @@
#include "InputChunks.h"
#include "WriterUtils.h"
#include "lld/Common/ErrorHandler.h"
+#include "lld/Common/LLVM.h"
#include "llvm/ADT/DenseMap.h"
-using llvm::raw_ostream;
-using llvm::raw_string_ostream;
-
namespace lld {
namespace wasm {
@@ -82,7 +80,7 @@ public:
std::string Body;
protected:
- raw_string_ostream BodyOutputStream;
+ llvm::raw_string_ostream BodyOutputStream;
};
class CodeSection : public OutputSection {
Modified: lld/trunk/wasm/SymbolTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/SymbolTable.cpp?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/wasm/SymbolTable.cpp (original)
+++ lld/trunk/wasm/SymbolTable.cpp Mon Nov 26 17:08:16 2018
@@ -20,6 +20,7 @@
using namespace llvm;
using namespace llvm::wasm;
+using namespace llvm::object;
using namespace lld;
using namespace lld::wasm;
Modified: lld/trunk/wasm/SymbolTable.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/SymbolTable.h?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/wasm/SymbolTable.h (original)
+++ lld/trunk/wasm/SymbolTable.h Mon Nov 26 17:08:16 2018
@@ -13,12 +13,9 @@
#include "InputFiles.h"
#include "LTO.h"
#include "Symbols.h"
+#include "lld/Common/LLVM.h"
#include "llvm/ADT/CachedHashString.h"
#include "llvm/ADT/DenseSet.h"
-#include "llvm/Support/raw_ostream.h"
-
-using llvm::wasm::WasmGlobalType;
-using llvm::wasm::WasmSignature;
namespace lld {
namespace wasm {
@@ -66,7 +63,7 @@ public:
Symbol *addUndefinedGlobal(StringRef Name, uint32_t Flags, InputFile *File,
const WasmGlobalType *Type);
- void addLazy(ArchiveFile *F, const Archive::Symbol *Sym);
+ void addLazy(ArchiveFile *F, const llvm::object::Archive::Symbol *Sym);
bool addComdat(StringRef Name);
Modified: lld/trunk/wasm/Symbols.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/Symbols.h?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/wasm/Symbols.h (original)
+++ lld/trunk/wasm/Symbols.h Mon Nov 26 17:08:16 2018
@@ -15,14 +15,11 @@
#include "llvm/Object/Archive.h"
#include "llvm/Object/Wasm.h"
-using llvm::object::Archive;
-using llvm::wasm::WasmGlobalType;
-using llvm::wasm::WasmSignature;
-using llvm::wasm::WasmSymbolType;
-
namespace lld {
namespace wasm {
+using llvm::wasm::WasmSymbolType;
+
class InputFile;
class InputChunk;
class InputSegment;
@@ -272,14 +269,15 @@ public:
class LazySymbol : public Symbol {
public:
- LazySymbol(StringRef Name, InputFile *File, const Archive::Symbol &Sym)
+ LazySymbol(StringRef Name, InputFile *File,
+ const llvm::object::Archive::Symbol &Sym)
: Symbol(Name, LazyKind, 0, File), ArchiveSymbol(Sym) {}
static bool classof(const Symbol *S) { return S->kind() == LazyKind; }
void fetch();
private:
- Archive::Symbol ArchiveSymbol;
+ llvm::object::Archive::Symbol ArchiveSymbol;
};
// linker-generated symbols
Modified: lld/trunk/wasm/WriterUtils.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/WriterUtils.h?rev=347621&r1=347620&r2=347621&view=diff
==============================================================================
--- lld/trunk/wasm/WriterUtils.h (original)
+++ lld/trunk/wasm/WriterUtils.h Mon Nov 26 17:08:16 2018
@@ -13,9 +13,6 @@
#include "lld/Common/LLVM.h"
#include "llvm/ADT/Twine.h"
#include "llvm/Object/Wasm.h"
-#include "llvm/Support/raw_ostream.h"
-
-using llvm::raw_ostream;
namespace lld {
namespace wasm {
More information about the llvm-commits
mailing list