[PATCH] D54758: [WebAssembly] Remove `using` statements from header files. NFC.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM. This is fine to me. We could create `lld/wasm/LLVM.h` to import Wasm* identifiers, but adding these identifiers directly to `llvm/Common/LLVM.h` makes more sense to me because the number of symbols we want to import is small.

> That does mean that lld/Common/LLVM.h will need to include llvm/Object/Wasm.h. It seems strange that has not been necessary for ELF/ COFF so far but I'll upload a new version this change and you can see what you think of it.

As you noticed, you don't actually have to include `llvm/Object/Wasm.h`. You just need to declare class/struct names in `lld/Common/LLVM.h`.



================
Comment at: include/lld/Common/LLVM.h:54
+  }
+  namespace wasm {
+    struct WasmFunction;
----------------
nit: add a blank line before a new namespace declaration.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54758/new/

https://reviews.llvm.org/D54758