[PATCH] D54759: [LLD][ELF] Use more specific method to calculate DT_PLTRELSZ

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1343
+    // overlap with the [DT_RELA, DT_RELA + DT_RELASZ).
+    Entries.push_back({DT_PLTRELSZ, [=] {
+                         size_t Size = In.RelaPlt->getSize();
----------------
It seems this lambda doesn't capture any variable, so this can be `[]`, no? It might be better to write this as a regular (outline) function, as this seems indented a bit too much.


================
Comment at: test/ELF/aarch64-combined-dynrel-ifunc.s:1
+// REQUIRES AArch64
+// RUN: llvm-mc -filetype=obj -triple=aarch64-linux-gnu %p/Inputs/shared.s -o %t-lib.o
----------------
Needs a colon after REQUIRES?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54759/new/

https://reviews.llvm.org/D54759