[PATCH] D54769: [FileCheck] New option -warn

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

Looks like we are unhappy with FileCheck for many  and different reasons:

1. we want to error for overlapping dag checks,
2. we want to error for the example in this diff: 1 but not all prefixes are checked,
3. we want a diagnostic for my motivating example in D53710 <https://reviews.llvm.org/D53710>: only labels are checked (check-prefixes are renamed/refactored/misspelled, but not the tags in tests accordingly)
4. CHECK-LABEL is confusing and probably mostly misunderstood

For me, 2) and 3) are really important, because very easily this results in tests not checking anything; as a result, we have serious test quality issues at the moment imo.

As I said, I agree we don't need a diagnostic mechanism for 2) as they can be errors. Tomorrow I will get the full list to get an impression how much work it will be to fix this.

I am unsure about 3), i.e. I can't remember/am unsure if we can avoid false positives. I will look into this again, or if someone can remind me that's fine too :-). But I thought this was the motivating case for emitting a diagnostic: if a false positive cannot be easily be avoided, an opt-in warning is the best we can do at the moment. The use case would indeed be to enable this while developing new tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54769/new/

https://reviews.llvm.org/D54769