[PATCH] D54877: Update coding guidelines regarding use of `auto`

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 26 15:34:05 PST 2018


zturner added a comment.

I'm against changes to the `auto` guidelines.  It is more important for code to be readable to other people, not yourself, because there is only 1 of you and there are many other people.  What I **explicitly do not want to happen** is for a reviewer to make a comment like "I find this unreadable" and then to have an author say "well it conforms to the style guidelines, so I'm going to keep it as is".

If people find code unreadable, even for subjective reasons, it has to change.  Full stop.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54877/new/

https://reviews.llvm.org/D54877





More information about the llvm-commits mailing list