[PATCH] D54915: [clang][slh] add attribute for speculative load hardening

[Zola Bridges via Phabricator via llvm-commits]

zbrid marked 2 inline comments as done.
zbrid added inline comments.


================
Comment at: clang/test/Misc/pragma-attribute-supported-attributes-list.test:119
 // CHECK-NEXT: SetTypestate (SubjectMatchRule_function_is_member)
+// CHECK-NEXT: SpeculativeLoadHardening (SubjectMatchRule_function, SubjectMatchRule_objc_method)
 // CHECK-NEXT: SwiftContext (SubjectMatchRule_variable_is_parameter)
----------------
This is the other change (also see line 5) that fixed a test which was failing the build after committing the last diff.


================
Comment at: clang/test/SemaCXX/attr-speculative-load-hardening.cpp:19
+
+int ci [[clang::speculative_load_hardening]]; // expected-error {{'speculative_load_hardening' attribute only applies to functions}}
+
----------------
I didn't have the clang namespace on the attributes here after changing the spelling to Clang from CXX11.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54915/new/

https://reviews.llvm.org/D54915