[PATCH] D54913: [ICP] Remove incompatible attributes at indirect-call promoted callsites.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/Utils/CallPromotionUtils.cpp:415
+      NewArgAttrs.push_back(AttributeSet::get(Ctx, ArgAttrs));
+      continue;
     }
----------------
use 'else' instead of continue?


================
Comment at: lib/Transforms/Utils/CallPromotionUtils.cpp:426
+  // Remove any incompatible return value attribute.
+  AttrBuilder RAttrs(CallerPAL, AttributeList::ReturnIndex);
+  RAttrs.remove(AttributeFuncs::typeIncompatible(CalleeRetTy));
----------------
Guard the following change with a flag : attributeChanged?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54913/new/

https://reviews.llvm.org/D54913