[PATCH] D54769: [FileCheck] New option -warn

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

>> Sounds like that could be an error, rather than a warning, perhaps?

While I agree with the observation, practically it would a lot easier to start small with a warning, clean things up, and then either promote warnings into errors, or make this particular warning an error. I've spent quite some time just looking at only 2 subdirectories, and fixed only one. Making this an error now would break tests, so we would need one big-bang commit to fix all tests first. I am okay spending time on this, but this is going to take some time, and also for some broken codegen tests I would probably need advise.

> We can always do that later if we decide the warning is reasonable enough of the time.

So for these reasons, this would definitely be my preferred approach.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54769/new/

https://reviews.llvm.org/D54769