[PATCH] D54483: [ELF] .gdb_index: use lower_bound to compute relative CU index in an object file
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 26 12:23:22 PST 2018
MaskRay added a comment.
Thanks that dblaikie gave his point. Should we move forward with this revision? This patch makes the code correct in this corner case that gold would fail at the cost of one more line. The local `lower_bound` usage is indeed a bit uglier but it shouldn't be a huge problem. When more needs emerge we can add a utility to `STLExtras.h` and improve the binary search call sites like this place.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54483/new/
https://reviews.llvm.org/D54483
More information about the llvm-commits
mailing list