Review request (was Re: [PATCH] D53736: [BTF] Add BTF DebugInfo)

[Yonghong Song via llvm-commits]

Hi, Eric,

I have not seen your review yet. It will be good if we can get
your opinion soon so we can move this project forward. If I
understand correctly (based on various information), you are
the final yes/no gatekeeper for a feature like this?
Sorry if I am wrong as I am not
a regular contributor to llvm debug_info area.

Thanks!

Yonghong


On 11/5/18 9:42 AM, Eric Christopher wrote:
> I've been out of town on vacation. This patch is on my list to review as 
> soon as I can.
> 
> -eric
> 
> On Fri, Nov 2, 2018 at 3:35 PM Yonghong Song <yhs at fb.com 
> <mailto:yhs at fb.com>> wrote:
> 
> 
>     Hi, David and Eric,
> 
>     Any opinion on this patch? Adrian mostly okay with the patch except
>     some possible refactoring. It would be good to get your opinion so
>     we can move the project forward.
> 
>     Thanks!
> 
>     Yonghong
> 
> 
>     On 10/31/18 4:29 PM, Alexei Starovoitov via Phabricator wrote:
>      > ast accepted this revision.
>      > ast added a comment.
>      > This revision is now accepted and ready to land.
>      >
>      > Eric, David, any objections to land it now?
>      > It's orthogonal to everything else in the llvm land and we'll
>     keep working on it for foreseeable future.
>      > All comments were addressed and any further refactoring requests
>     can be done later.
>      > I'd like to avoid sitting on it for too long, since a bunch of
>     folks in bpf community are waiting on it.
>      > We have two large sets of kernel patches that depend on it.
>      > We'd like to land llvm bits first, so our kernel test bots can do
>     testing with latest llvm trunk and latest kernel tree asap.
>      >
>      >
>      > Repository:
>      >    rL LLVM
>      >
>      >
>     https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D53736&d=DwIFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=Ew1MQ_MuKfrmZD6WfVqlNmbhAJNSt4WvT-AwUHD7Z0A&s=VDCS1P8iGI26lJfKjl6UVjUNIv0ap7jP8YrI1aivzZ4&e=
>      >
>      >
>      >
>