[PATCH] D54883: [Support/FileSystem] Use st_atimespec only when __APPLE__ is defined

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 26 11:35:09 PST 2018


krytarowski added a comment.

I'm expressing that swapping feature detection to OS checks is inferior and makes this code worse, I gave to illustrations when it makes a lot of harm. I don't agree with this patch regardless of what OS in what version when adopted one or the another form (or none of them).

If you have problems replacing cmake with something else, it's not a problem in LLVM.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54883/new/

https://reviews.llvm.org/D54883





More information about the llvm-commits mailing list