[PATCH] D54828: [LLD] [COFF] Generate a codeview build id signature for MinGW even when not creating a PDB

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Writer.cpp:1574
+
+  if (GenerateBuildId) {
+    BuildId->BuildId->PDB70.CVSignature = OMF::Signature::PDB70;
----------------
I think `Config->MinGW && Config->Debug && Config->PDBPath.empty()` is fine, but it seems this code needs a bit more explanation, because we create build id even if `GenerateBuildId` is false (if we are creating a PDB file.)


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54828/new/

https://reviews.llvm.org/D54828