[PATCH] D54504: [stack-safety] Local analysis implementation

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added a comment.

I've been busy and still haven't had a chance to run down why the behavior of %z in the NonConstantOffset() test changes so oddly with different select values.



================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:135
+// more of its arguments.
+struct llvm::StackSafetyFunctionInfo {
+  // May be a Function or a GlobalAlias
----------------
vitalybuka wrote:
> vlad.tsyrklevich wrote:
> > This uses a different naming convention than the structs above though it's part of the same 'type set' as the *Info structs above which is confusing. Couldn't immediately think of a fix that makes it nicer though. Might just be worth a comment to at least be explicit about why this is.
> renamed
> WDYT?
Looks good, 'FunctionStackSummary' still needs to be updated and that comment should also have a TODO or FIXME to indicate it's a future idea.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:29
+///
+/// The implementation simply replaces all mentions of the alloca with zero.
+class AllocaOffsetRewriter : public SCEVRewriteVisitor<AllocaOffsetRewriter> {
----------------
"mentions of the alloca in addition expressions with zero" (I didn't update the comment after this change was made.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54504/new/

https://reviews.llvm.org/D54504