[PATCH] D54769: [FileCheck] New option -warn

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D54769#1306275 <https://reviews.llvm.org/D54769#1306275>, @SjoerdMeijer wrote:

> I decided to continue here, and implemented the diagnostic that Paul suggested in the other ticket, because it's small and a nice demonstrator for this new option:
>
> > Another useful diagnostic (probably best done separately) would be when a given prefix triggers no directives at all. That's obviously an incorrect test; either it has typos or has a dangling -check-prefix whose directives have all been removed. Right now, this diagnostic occurs only when there are no matching directives at all. But if you specify two prefixes, and only one of them matches a directive, FileCheck is silent. I think that's bad.


Sounds like that could be an error, rather than a warning, perhaps?

(in general I'm a bit hesitant to add warnings - either these checks are things we can all agree on are erroneous & should be a failure, or warning cruft will accumulate and make the noise too high for the warning signals to be seen?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54769/new/

https://reviews.llvm.org/D54769