[PATCH] D54052: Support for inserting profile-directed cache prefetches

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 26 10:21:45 PST 2018


mtrofin added a comment.

In D54052#1304382 <https://reviews.llvm.org/D54052#1304382>, @craig.topper wrote:

> Weird. I thought I wrote some comments last week, but they obviously didn’t make it in here. Guess I’ll redo that today when I get to the office. One thing I remember is that this patch uses ‘auto’ more than llvm prefers https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable


Thanks - addressed the use of 'auto' throughout the change.

Please let me know if there is anything else I should address.

Thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54052/new/

https://reviews.llvm.org/D54052





More information about the llvm-commits mailing list