[PATCH] D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/AArch64.cpp:46
   bool usesOnlyLowPageBits(RelType Type) const override;
-  void relocateOne(uint8_t *Loc, RelType Type, uint64_t Val) const override;
+  void relocateOne(uint8_t *Loc, RelType Type, uint64_t Val,
+                   const Symbol *S = nullptr) const override;
----------------
MaskRay wrote:
> I like this change.
> 
> With `const Symbol *S`, we can improve error reporting of relocation overflow of `checkUInt(...)`
Adding `const Symbol *` to `relocateOne` might be fine, but I don't like to add a default argument to the parameter. How many locations do we call `relocateOne`? Can we just always pass a symbol to the function?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D40147/new/

https://reviews.llvm.org/D40147