[PATCH] D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM with these changes.



================
Comment at: ELF/Arch/PPC.cpp:41
   case R_PPC_REL24:
+  case R_PPC_REL14:
   case R_PPC_REL32:
----------------
MaskRay wrote:
> 14 24 32 may feel more natural
Yup, please sort.


================
Comment at: ELF/Arch/PPC.cpp:70-72
+  case R_PPC_REL14:
+    write32be(Loc, read32be(Loc) | (Val & 0xFFFC));
+    break;
----------------
Add this before REL24, instead of adding to the end of the existing code.


================
Comment at: ELF/Arch/PPC64.cpp:703
   }
+  case R_PPC64_REL14: {
+    uint32_t Mask = 0x0000FFFC;
----------------
Ditto


================
Comment at: ELF/Arch/PPC64.cpp:721
   // The only call relocation we currently support is the REL24 type.
-  if (Type != R_PPC64_REL24)
+  if (Type != R_PPC64_REL24 && Type != R_PPC64_REL14)
     return false;
----------------
Ditto


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54868/new/

https://reviews.llvm.org/D54868