[PATCH] D54859: [PPC64] Support got relocations

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 26 09:18:46 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/ppc64-got-off.s:8
+
+        .abiversion 2
+        .section ".text"
----------------
sfertile wrote:
> MaskRay wrote:
> > The file seems to mix tabs and spaces.
> Do you mean the 8-spacing on the directives vs the 4 spacing on the instructions? Thats how I typically write in assembly. I don't mind cleaning that up to a consistent spacing for all though.
I don't mind too much about coding style of test assembly files, so this is fine. If we want to enforce some formatting, we probably should reformat all the existing assembly files in this directory, but that's probably an unwanted churn.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54859/new/

https://reviews.llvm.org/D54859





More information about the llvm-commits mailing list