[PATCH] D54755: [DebugInfo] IR/Bitcode changes for DISubprogram flags

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

I'm assuming we already have plenty of DISubprograms with flags in the old format as .bc tests that cover the bitcode upgrade?



================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1645
   Record.push_back(VE.getMetadataOrNullID(N->getType()));
-  Record.push_back(N->isLocalToUnit());
-  Record.push_back(N->isDefinition());
+  Record.push_back(0); // unused
+  Record.push_back(0); // unused
----------------
Am I right in assuming that these dead fields take up virtually no extra space in the bitcode? Otherwise we might want to add an extra bit distinguish old vs. a newer, more compact record layout.


================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:554
+  switch (Flag) {
+  case SPFlagVirtuality: // Appease a warning.
+    return "";
----------------
nit: comment should go on the line before.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54755/new/

https://reviews.llvm.org/D54755