[PATCH] D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON

Michael Platings via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 26 07:07:29 PST 2018


michaelplatings updated this revision to Diff 175250.
michaelplatings added a comment.

(moved closing parenthesis to new line)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54701/new/

https://reviews.llvm.org/D54701

Files:
  unittests/Support/DynamicLibrary/CMakeLists.txt


Index: unittests/Support/DynamicLibrary/CMakeLists.txt
===================================================================
--- unittests/Support/DynamicLibrary/CMakeLists.txt
+++ unittests/Support/DynamicLibrary/CMakeLists.txt
@@ -8,6 +8,13 @@
   )
 set_target_properties(DynamicLibraryLib PROPERTIES FOLDER "Tests")
 
+# extract_symbols.py relies on all its library arguments being in the same
+# directory, so we must set the output directory in the same way as if
+# add_llvm_library was used.
+set_output_directory(DynamicLibraryLib
+  LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}
+  )
+
 add_llvm_unittest(DynamicLibraryTests
   DynamicLibraryTest.cpp
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54701.175250.patch
Type: text/x-patch
Size: 659 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181126/905547a3/attachment.bin>


More information about the llvm-commits mailing list