[PATCH] D54864: Introduce llvm-objdump man page

[Ed Maste via Phabricator via llvm-commits]

emaste added inline comments.


================
Comment at: usr.bin/clang/llvm-objdump/llvm-objdump.1:218
+.Fl -macho .
+.It Fl -print-after-all
+Print IR after each pass.
----------------
emaste wrote:
> MaskRay wrote:
> > `-print-after-all` is a legacy PM option defined in `lib/IR/LegacyPassManager.cpp`. llvm-objdump doesn't need it.
> > 
> > These `cl::opt` options should at some point be refactored to use tablegen as llvm-objcopy does...
> Will delete.
Presumably `--print-before-all` also.


================
Comment at: usr.bin/clang/llvm-objdump/llvm-objdump.1:238
+Seed for the random number generator.
+.It Fl s
+Display the content of each section.
----------------
emaste wrote:
> MaskRay wrote:
> > It should be accompanied by `-full-sections`. My preference is that these options are sorted and aligned by their full names and the single-letter aliases follow (not following GNU convention), as what `lld/docs/ld.lld1.1` does:
> > 
> > ```
> > .It Fl -emit-relocs , Fl q
> > Generate relocations in the output.
> > .It Fl -enable-new-dtags
> > Enable new dynamic tags.
> > ```
> > 
> It was pointed out in some ld.lld.1 review that preference should be for sorting by short option, but I believe that some of the short options are still not listed in ld.lld.1.
Note GNU objdump lists `-s|--full-contents`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54864/new/

https://reviews.llvm.org/D54864