[PATCH] D54867: [yaml2obj] Make sh_info field editable in raw content section

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 26 01:37:13 PST 2018


jhenderson added a comment.

Whilst I'm not opposed to this in principle, I do wonder if the more correct thing to do is to make .gnu.version_r sections (which I assume have a distinctive ELF type) another kind of ELFYAML section (e.g. like RelocationSection).

I also think a refactor of the error handling is in order. Specifically, basically the same four lines of code exist any time Info or Link can be set. This should probably be pulled out into a separate function. Something like `checkSectionIndex` or similar.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54867/new/

https://reviews.llvm.org/D54867





More information about the llvm-commits mailing list