[PATCH] D54871: [ELF] Allow discarding of .rela.plt

Sun Nov 25 23:59:12 PST 2018

grimar added a comment.

This is probably fine. The test was introduced in D41640 <https://reviews.llvm.org/D41640>.

Before D41640 <https://reviews.llvm.org/D41640> the constructions like `/DISCARD/ : { *(.rela.plt)` were completely ignored,
but after that patch, we could discard them or report an error.

I think we report an error just because it seems uncommon for scripts to discard this section
and we never faced that before. I assume your script do that, is it correct?
(I did not find how the macro `DISCARDS` expands in
https://github.com/spotify/linux/blob/master/arch/powerpc/kernel/vmlinux.lds.S#L262)

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54871/new/

https://reviews.llvm.org/D54871