[PATCH] D54884: [bugpoint] Find 'opt', etc., in bugpoint directory

[Brian Gesiak via Phabricator via llvm-commits]

modocache created this revision.
modocache added reviewers: MatzeB, silvas.

When bugpoint attempts to find the other executables it needs to run,
such as `opt` or `clang`, it tries searching the user's PATH. However,
in many cases, the 'bugpoint' executable is part of an LLVM build, and
the 'opt' executable it's looking for is in that same directory.

Many LLVM tools handle this case by using the `Paths` parameter of
`llvm::sys::findProgramByName`, passing the parent path of the currently
running executable. Do this same thing for bugpoint. However, to
preserve the current behavior exactly, first search the user's PATH,
and then search for 'opt' in the directory containing 'bugpoint'.

Test Plan:
`check-llvm`. Many of the existing bugpoint tests no longer need to use the
`--opt-command` option as a result of these changes.


Repository:
  rL LLVM

https://reviews.llvm.org/D54884

Files:
  test/BugPoint/compile-custom.ll
  test/BugPoint/crash-narrowfunctiontest.ll
  test/BugPoint/invalid-debuginfo.ll
  test/BugPoint/metadata.ll
  test/BugPoint/named-md.ll
  test/BugPoint/remove_arguments_test.ll
  test/BugPoint/replace-funcs-with-null.ll
  tools/bugpoint/ExecutionDriver.cpp
  tools/bugpoint/OptimizerDriver.cpp
  tools/bugpoint/ToolRunner.cpp
  tools/bugpoint/ToolRunner.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54884.175195.patch
Type: text/x-patch
Size: 16945 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181126/68a37c66/attachment-0001.bin>