[PATCH] D53892: [CodeGen] Support custom format of stack maps

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM

We can continue the discussion around finalizeModule and emitStackMaps separately.  It's definitely not a blocker for this patch.



================
Comment at: include/llvm/CodeGen/GCMetadataPrinter.h:68
+  /// returns false and the default format will be used.
+  virtual bool emitStackMaps(StackMaps &SM, AsmPrinter &AP) { return false; }
 };
----------------
reames wrote:
> This new call is arguably duplicating the existing finishModule callback.  It'd be nice to find a way to merge the two honestly.  
In case my tone was unclear, this was not a must fix.  It was a please think about it, and share any ideas you might have.  If we can't find the right abstraction, I'm fine with this landing with the new API.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53892/new/

https://reviews.llvm.org/D53892