[PATCH] D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 25 16:49:49 PST 2018


MaskRay added inline comments.


================
Comment at: ELF/Arch/AArch64.cpp:46
   bool usesOnlyLowPageBits(RelType Type) const override;
-  void relocateOne(uint8_t *Loc, RelType Type, uint64_t Val) const override;
+  void relocateOne(uint8_t *Loc, RelType Type, uint64_t Val,
+                   const Symbol *S = nullptr) const override;
----------------
I like this change.

With `const Symbol *S`, we can improve error reporting of relocation overflow of `checkUInt(...)`


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D40147/new/

https://reviews.llvm.org/D40147





More information about the llvm-commits mailing list