[PATCH] D54855: [AMDGPU] An exp must be branched over if exec=0

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 25 14:34:03 PST 2018


nhaehnle added a comment.

This should already be fixed in trunk. Trunk has a function TII->hasUnwantedEffectsWhenEXECEmpty to cover this, and this patch simply shouldn't apply.

I vaguely recall you complained about those changes I made and backed them out of the Vulkan branch because of some pixel shader case where some bad lowering happened? I don't remember the details right now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54855/new/

https://reviews.llvm.org/D54855





More information about the llvm-commits mailing list