[PATCH] D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms

Argyrios Kyrtzidis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 25 13:21:22 PST 2018


akyrtzi marked an inline comment as done.
akyrtzi added inline comments.


================
Comment at: include/llvm/Config/config.h.cmake:212
+/* Define to 1 if stat struct has st_mtimespec member, and to 0 if it doesn't.*/
+#cmakedefine01 HAVE_STRUCT_STAT_ST_MTIMESPEC_TV_NSEC
+
----------------
aaron.ballman wrote:
> Is there a reason to not use `#cmakedefine` like the other uses?
This file is not consistent on what it uses, it has uses of `#cmakedefine01` in some places but majority is with `#cmakedefine`.
I mainly liked to use `#if HAVE_STRUCT_STAT.. ` directly since it reads more naturally, but if you prefer it the other way I will switch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54826/new/

https://reviews.llvm.org/D54826





More information about the llvm-commits mailing list