[PATCH] D54875: [WebAssembly] Add support for the event section

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 25 00:48:23 PST 2018


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: wasm/InputEntity.h:31
+
+class InputEntity {
+public:
----------------
This is supposed to be the parent class for both `InputGlobal` and `InputEvent`, and I'm not sure if this is a good name. I also thought about `InputNonChunk`, but that didn't sound very intuitive either. Suggestions are welcome.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54875/new/

https://reviews.llvm.org/D54875





More information about the llvm-commits mailing list