[PATCH] D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms
Kristina Brooks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 25 00:10:18 PST 2018
kristina requested changes to this revision.
kristina added a comment.
This revision now requires changes to proceed.
Do we really need nanosecond precision with regards to this? The general changes to the support libraries are usually facilitated because of missing functionality that is required somewhere else and it being the most logical place to add it. If so please attach related revisions to this one (through "Edit Related Objects") so it's more clear why this was added. However, if there's no consumer for such API (pending review) there is no point in adding it. The main spirit of the library is to only provide what LLVM and related projects require, I don't think nanosecond precision support falls within that category (unless what I said earlier is the case, in which case please link it to this revision).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54826/new/
https://reviews.llvm.org/D54826
More information about the llvm-commits
mailing list