[PATCH] D54758: [WebAssembly] Remove `using` statements from header files. NFC.

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 25 00:00:15 PST 2018


kristina added a comment.

I think some redundant includes should definitely go (IWYU). Regarding more granular `using` declarations, honestly it's up to @ruiu, Clang and LLDB handle it by aliasing some of LLVM's common classes in their respective namespaces, maybe that could work for LLD too? In fact I'm guessing that's the purpose of `lld/Common/LLVM.h`, you could take a similar approach for Wasm specific stuff and limit the using statements to your namespace.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54758/new/

https://reviews.llvm.org/D54758





More information about the llvm-commits mailing list