[PATCH] D53461: [X86][compiler-rt] Add additional CPUs and features to the cpu detection to match libgcc

[Craig Topper via llvm-commits]

Hopefully the warning is fixed after r347516. Sorry for the delay.

~Craig


On Tue, Nov 20, 2018 at 11:18 AM Roman Lebedev via Phabricator <
reviews at reviews.llvm.org> wrote:

> lebedev.ri added inline comments.
>
>
> ================
> Comment at: compiler-rt/trunk/lib/builtins/cpu_model.c:467-468
> +  do {                             \
> +    if (F < 32)                    \
> +      Features |= 1 << F;          \
> +    else if (F < 64)               \
> ----------------
> F = 31
> F < 32
> 1 << 31
> 2147483648
> which is just the sign bit set
>
> This should probably be
> ```
> Features |= 1U << F;
> ```
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D53461
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181124/0b46e4ec/attachment.html>