[PATCH] D54803: [x86] promote all multiply i8 by constant to i32

Sat Nov 24 10:58:20 PST 2018

spatel updated this revision to Diff 175163.
spatel added a comment.

Patch updated:
After looking again, Roman's analysis was correct - the previous logic was bogus. But I'm not sure if we could expose the bug because of the interaction of these 2 hooks. Ie, the test diffs in this version of the patch are unchanged from before.

In any case, updated the code and comments to hopefully be clearer now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54803/new/

https://reviews.llvm.org/D54803

Files:
  lib/Target/X86/X86ISelLowering.cpp
  test/CodeGen/X86/ipra-reg-alias.ll
  test/CodeGen/X86/load-scalar-as-vector.ll
  test/CodeGen/X86/mul-constant-i8.ll
  test/CodeGen/X86/urem-i8-constant.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54803.175163.patch
Type: text/x-patch
Size: 21347 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181124/c5781e30/attachment.bin>