[PATCH] D54869: [InstCombine] Determine demanded and known bits for funnel shifts

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 24 09:47:36 PST 2018


spatel accepted this revision.
spatel added a subscriber: nagisa.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM. I don't know if vector types will show the same simplifications, but it would be nice to have at least one of the tests repeated with a vector type, so we know if that is missing or works as expected.

Also, I know we're not getting the motivating case due to multi-use, and I agree with @nagisa that it should be filed as a bug report because I'm also not sure how to solve it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54869/new/

https://reviews.llvm.org/D54869





More information about the llvm-commits mailing list