[PATCH] D54864: Introduce llvm-objdump man page

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: usr.bin/clang/llvm-objdump/llvm-objdump.1:12
+.Nm llvm-objdump
+.Op Fl -aarch64-neon-syntax Ns = Ns Ar value
+.Op Fl -arch Ns = Ns Ar value
----------------
It does not seem very necessary to list all options in SYNOPSIS.


================
Comment at: usr.bin/clang/llvm-objdump/llvm-objdump.1:218
+.Fl -macho .
+.It Fl -print-after-all
+Print IR after each pass.
----------------
`-print-after-all` is a legacy PM option defined in `lib/IR/LegacyPassManager.cpp`. llvm-objdump doesn't need it.

These `cl::opt` options should at some point be refactored to use tablegen as llvm-objcopy does...


================
Comment at: usr.bin/clang/llvm-objdump/llvm-objdump.1:238
+Seed for the random number generator.
+.It Fl s
+Display the content of each section.
----------------
It should be accompanied by `-full-sections`. My preference is that these options are sorted and aligned by their full names and the single-letter aliases follow (not following GNU convention), as what `lld/docs/ld.lld1.1` does:

```
.It Fl -emit-relocs , Fl q
Generate relocations in the output.
.It Fl -enable-new-dtags
Enable new dynamic tags.
```



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54864/new/

https://reviews.llvm.org/D54864