[PATCH] D54778: [InstCombine] Simplify funnel shift with one zero/undef operands to simple shift

[Nikita Popov via Phabricator via llvm-commits]

nikic marked 2 inline comments as done.
nikic added a comment.

I've added some vector tests before committing. Thanks for the reviews!



================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:2008-2009
+      if (match(Op1, m_Zero()) || match(Op1, m_Undef()))
+        return BinaryOperator::CreateShl(Op0,
+          ConstantInt::get(II->getType(), ShiftAmt));
+
----------------
spatel wrote:
> Here and below - did that clang-format like that? Doesn't look like the normal indent.
You're right, I fixed this before commit. TIL about git clang-format.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54778/new/

https://reviews.llvm.org/D54778