[PATCH] D54778: [InstCombine] Simplify funnel shift with one zero/undef operands to simple shift

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - can you add at least one vector test when before committing, so we know that the constant creation is producing the correct types.



================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:2008-2009
+      if (match(Op1, m_Zero()) || match(Op1, m_Undef()))
+        return BinaryOperator::CreateShl(Op0,
+          ConstantInt::get(II->getType(), ShiftAmt));
+
----------------
Here and below - did that clang-format like that? Doesn't look like the normal indent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54778/new/

https://reviews.llvm.org/D54778