[PATCH] D54842: [ARM][NFC] codegen tests cleanup: remove dangling check prefixes

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 23 01:16:09 PST 2018


SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: samparker, olista01.
Herald added subscribers: chrib, kristof.beyls, javed.absar.

I am working on making FileCheck stricter (in https://reviews.llvm.org/D54769 and https://reviews.llvm.org/D53710) so that it issues diagnostics when there's something wrong with tests.

This is a cleanup for dangling prefixes in the ARM codegen tests:

    
  --check-prefixes=A,B

where A occurs in the check file, but B doesn't. This can be innocent if A does all the required checking, but can also be a bug in that test if it results in the test actually not checking  anything if A only checks a common label. Test CodeGen/ARM/smml.ll is such an example


https://reviews.llvm.org/D54842

Files:
  test/CodeGen/ARM/CGP/arm-cgp-phis-ret.ll
  test/CodeGen/ARM/GlobalISel/arm-select-globals-ropi-rwpi.mir
  test/CodeGen/ARM/float-helpers.s
  test/CodeGen/ARM/ldrd.ll
  test/CodeGen/ARM/smml.ll
  test/CodeGen/ARM/softfp-fabs-fneg.ll
  test/CodeGen/ARM/tls-models.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54842.175088.patch
Type: text/x-patch
Size: 10344 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181123/b1c1aedb/attachment.bin>


More information about the llvm-commits mailing list