[PATCH] D54835: tsan: Support calling ThreadCreate()/ThreadStart()/ThreadFinish() for non-current thread

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 23 00:34:45 PST 2018


dvyukov added a comment.

In https://reviews.llvm.org/D54835#1306431, @yuri wrote:

> I have working implemented of fibers (coroutines)  support for thread sanitizer. 
>  Taking in the account that fibers are supported by address sanitizer, support in thread sanitizer may be useful as well.
>
> This is a first patch of the changeset. Please advise, what is the preferred process of reviewing in such cases: submit patches one-by-one or submit the entire changeset?


Hi Yuri,

Fibers support sounds great.
Regardless of how we proceed with submitting patches, I would like to see the whole change first. Otherwise it's hard to see reasoning behind individual changes and understand if it's right approach or not.
Please upload whole change into a separate review.

Thanks


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54835





More information about the llvm-commits mailing list