[llvm] r347448 - Revert r343473 "Move llvm util dependencies from clang-tools-extra to add_lit_target."

Haojian Wu via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 22 02:14:24 PST 2018


Author: hokein
Date: Thu Nov 22 02:14:24 2018
New Revision: 347448

URL: http://llvm.org/viewvc/llvm-project?rev=347448&view=rev
Log:
Revert r343473 "Move llvm util dependencies from clang-tools-extra to add_lit_target."

Summary:
It will cause test tools `FileCheck`, `count`, `not` being built blindly, these
dependencies should move back to clang-tools-extra.

Reviewers: mgorny

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D54797

Modified:
    llvm/trunk/cmake/modules/AddLLVM.cmake

Modified: llvm/trunk/cmake/modules/AddLLVM.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=347448&r1=347447&r2=347448&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/AddLLVM.cmake (original)
+++ llvm/trunk/cmake/modules/AddLLVM.cmake Thu Nov 22 02:14:24 2018
@@ -1374,16 +1374,6 @@ function(add_lit_target target comment)
     message(STATUS "${target} does nothing.")
   endif()
 
-  # Add lit test dependencies.
-  set(llvm_utils_deps
-    FileCheck count not
-  )
-  foreach(dep ${llvm_utils_deps})
-    if (TARGET ${dep})
-      add_dependencies(${target} ${dep})
-    endif()
-  endforeach()
-
   if (ARG_DEPENDS)
     add_dependencies(${target} ${ARG_DEPENDS})
   endif()




More information about the llvm-commits mailing list