[PATCH] D54025: [LoopSimplifyCFG] Delete dead exiting edges

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopSimplifyCFG.cpp:256
+  ///
+  ///  preheader-split:
+  ///    <preheader code>
----------------
need to have the label name matching the switch (new_preheader vs preheader-split)


================
Comment at: lib/Transforms/Scalar/LoopSimplifyCFG.cpp:262
+  ///    ...
+  ///    br i1 false, label %dead_exit, label %loop_block
+  ///    ...
----------------
%dead_exit_N ?


================
Comment at: lib/Transforms/Scalar/LoopSimplifyCFG.cpp:272
+
+    // Split preheader like this:
+    DomTreeUpdater DTU(DT, DomTreeUpdater::UpdateStrategy::Eager);
----------------
Stray comment?


https://reviews.llvm.org/D54025