[PATCH] D54818: [SelectionDAG] Teach BaseIndexOffset::match to unwrap the base after looking through an add/or

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added a reviewer: niravd.
Herald added a subscriber: arphaman.

We might find a target specific node that needs to be unwrapped after we look through an add/or. Otherwise we get inconsistent results if one pointer is just X86WrapperRIP and the other is (add X86WrapperRIP, C)

The test that changed hasn't been commited yet. I'll commit if/when this patch is approved.


https://reviews.llvm.org/D54818

Files:
  lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp
  test/CodeGen/X86/consecutive-load-shuffle.ll


Index: test/CodeGen/X86/consecutive-load-shuffle.ll
===================================================================
--- test/CodeGen/X86/consecutive-load-shuffle.ll
+++ test/CodeGen/X86/consecutive-load-shuffle.ll
@@ -11,9 +11,8 @@
 define void @foo2() {
 ; CHECK-LABEL: foo2:
 ; CHECK:       # %bb.0: # %entry
-; CHECK-NEXT:    movsd {{.*#+}} xmm0 = mem[0],zero
-; CHECK-NEXT:    movhpd {{.*#+}} xmm0 = xmm0[0],mem[0]
-; CHECK-NEXT:    movapd %xmm0, {{.*}}(%rip)
+; CHECK-NEXT:    movaps {{.*}}(%rip), %xmm0
+; CHECK-NEXT:    movaps %xmm0, {{.*}}(%rip)
 ; CHECK-NEXT:    retq
 entry:
   %0 = load <2 x float>, <2 x float>* bitcast (float* getelementptr inbounds ([4 x float], [4 x float]* @f, i64 0, i64 2) to <2 x float>*), align 8
Index: lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp
===================================================================
--- lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp
+++ lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp
@@ -107,14 +107,14 @@
       if (auto *C = dyn_cast<ConstantSDNode>(Base->getOperand(1)))
         if (DAG.MaskedValueIsZero(Base->getOperand(0), C->getAPIntValue())) {
           Offset += C->getSExtValue();
-          Base = Base->getOperand(0);
+          Base = DAG.getTargetLoweringInfo().unwrapAddress(Base->getOperand(0));
           continue;
         }
       break;
     case ISD::ADD:
       if (auto *C = dyn_cast<ConstantSDNode>(Base->getOperand(1))) {
         Offset += C->getSExtValue();
-        Base = Base->getOperand(0);
+        Base = DAG.getTargetLoweringInfo().unwrapAddress(Base->getOperand(0));
         continue;
       }
       break;
@@ -130,7 +130,7 @@
             Offset -= Off;
           else
             Offset += Off;
-          Base = LSBase->getBasePtr();
+          Base = DAG.getTargetLoweringInfo().unwrapAddress(LSBase->getBasePtr());
           continue;
         }
       break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54818.174991.patch
Type: text/x-patch
Size: 1916 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181121/b5d9f0f6/attachment.bin>