[PATCH] D54543: [stack-safety] Inter-Procedural Analysis implementation

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 21 15:39:32 PST 2018


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM with nit



================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:187
+  for (unsigned ArgNo = 0; ArgNo < Type->getNumParams(); ArgNo++) {
+    Params.emplace_back(DL.getPointerSizeInBits(), nullptr);
+    UseInfo &US = Params.back().Use;
----------------
getPointerSizeInBits implementation is not trivial, consider caching the result in StackSafetyLocalAnalysis


Repository:
  rL LLVM

https://reviews.llvm.org/D54543





More information about the llvm-commits mailing list