[PATCH] D54807: llvm-git: More tweaks.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 21 12:53:10 PST 2018


zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/utils/git-svn/git-llvm:327-328
         try:
-            # If we allow python to apply the diff in text mode, it will
-            # silently convert \n to \r\n which git doesn't like.
             shell(['git', 'apply', prefix_strip, '-'], cwd=svn_sr_path,
----------------
Should we retain the comment here about why we're passing `text=False`?


https://reviews.llvm.org/D54807





More information about the llvm-commits mailing list