[PATCH] D54143: [WIP, RISCV] Generate address sequences suitable for mcmodel=medium

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 21 10:19:37 PST 2018


jrtc27 added a comment.

In https://reviews.llvm.org/D54143#1305469, @rogfer01 wrote:

> In my downstream I have a single `RISCVISD::WRAPPER_PIC` and then I use a target flag to remember whether later we want just PCREL (lla) or GOT based on what `shouldAssumeDSOLocal` returns.
>
> But I agree that we can do instead what @jrtc27 suggests and then we can add a `PseudoLA` later (or something that explicitly means "via GOT" because a "la" with `-fno-PIC` is just a `lla`),


I don't see why `-fno-PIC` is relevant. If we have `-fno-PIC` we *want* whatever we pick to be an `lla`, so using `PseudoLA` for anything non-local is precisely what we want.


Repository:
  rL LLVM

https://reviews.llvm.org/D54143





More information about the llvm-commits mailing list