[PATCH] D54769: [FileCheck] New option -warn

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: test/FileCheck/check-warning.txt:3
+; RUN: FileCheck -warn=true -input-file %s %s 2>&1 | FileCheck -check-prefix=CHECK-WARNING %s
+; RUN: FileCheck -vv -warn=false -input-file %s %s 2>&1 | FileCheck -check-prefix=CHECK-ERROR %s
+
----------------
Why -vv?

Why -ERROR?  Wouldn't -QUIET make more sense?


================
Comment at: utils/FileCheck/FileCheck.cpp:211
 
+  FC.PrintWarning(SM, SMLoc(), "Running FileCheck with warnings enabled");
+
----------------
Is the purpose of this warning purely for testing your -warn implementation?  That is, do you plan to remove it upon committing D53710 (or some other warning)?

I'm imagining grepping through test suite output looking for FileCheck warnings to investigate, and this warning would be a pervasive distraction.


https://reviews.llvm.org/D54769