[PATCH] D54797: Revert r343473 "Move llvm util dependencies from clang-tools-extra to add_lit_target."

Haojian Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 21 07:07:41 PST 2018


hokein created this revision.
hokein added a reviewer: mgorny.

It will cause test tools `FileCheck`, `count`, `not` being built blindly, these
dependencies should move back to clang-tools-extra.


Repository:
  rL LLVM

https://reviews.llvm.org/D54797

Files:
  cmake/modules/AddLLVM.cmake


Index: cmake/modules/AddLLVM.cmake
===================================================================
--- cmake/modules/AddLLVM.cmake
+++ cmake/modules/AddLLVM.cmake
@@ -1374,16 +1374,6 @@
     message(STATUS "${target} does nothing.")
   endif()
 
-  # Add lit test dependencies.
-  set(llvm_utils_deps
-    FileCheck count not
-  )
-  foreach(dep ${llvm_utils_deps})
-    if (TARGET ${dep})
-      add_dependencies(${target} ${dep})
-    endif()
-  endforeach()
-
   if (ARG_DEPENDS)
     add_dependencies(${target} ${ARG_DEPENDS})
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54797.174924.patch
Type: text/x-patch
Size: 546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181121/26a99104/attachment.bin>


More information about the llvm-commits mailing list