[PATCH] D54786: [LLD][ARM] Change REQUIRES: ARM to Requires: arm

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 21 02:50:07 PST 2018


peter.smith created this revision.
peter.smith added reviewers: ruiu, grimar.
Herald added subscribers: chrib, kristof.beyls, arichardson, javed.absar, emaste.
Herald added a reviewer: espindola.

When REQUIRES: ARM is used the test is skipped as ARM is not recognized. Change to REQUIRES: arm so that it is run. This required updating one of the tests due to changes in expected output. In this case the name of a mapping symbol changed, as this wasn't important to the test so I removed the line.


https://reviews.llvm.org/D54786

Files:
  test/ELF/arm-thunk-nosuitable.s
  test/ELF/arm-thunk-section-too-large.s


Index: test/ELF/arm-thunk-section-too-large.s
===================================================================
--- test/ELF/arm-thunk-section-too-large.s
+++ test/ELF/arm-thunk-section-too-large.s
@@ -1,4 +1,4 @@
-// REQUIRES: ARM
+// REQUIRES: arm
 // RUN: llvm-mc %s -triple=armv7a-linux-gnueabihf -arm-add-build-attributes -filetype=obj -o %t.o
 // RUN: not ld.lld %t.o -o /dev/null 2>&1 | FileCheck %s
 
Index: test/ELF/arm-thunk-nosuitable.s
===================================================================
--- test/ELF/arm-thunk-nosuitable.s
+++ test/ELF/arm-thunk-nosuitable.s
@@ -1,4 +1,4 @@
-// REQUIRES: ARM
+// REQUIRES: arm
 // RUN: llvm-mc %s --arm-add-build-attributes --triple=armv7a-linux-gnueabihf --filetype=obj -o %t.o
 // RUN: ld.lld %t.o -o %t
 // RUN: llvm-objdump -triple=thumbv7a-linux-gnueabihf -d -start-address=2166784 -stop-address=2166794 %t | FileCheck %s
@@ -23,8 +23,7 @@
 // CHECK-NEXT:   211000:        00 f0 00 80     beq.w   #0
 // CHECK: __Thumbv7ABSLongThunk_target:
 // CHECK-NEXT:   211004:        00 f0 01 90     b.w     #12582914
-// CHECK: $t.1:
-// CHECK-NEXT:   211008:        70 47   bx      lr
+// CHECK:        211008:        70 47   bx      lr
 
         .section .text.2, "ax", %progbits
         .space 12 * 1024 * 1024


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54786.174891.patch
Type: text/x-patch
Size: 1277 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181121/6b9276d3/attachment.bin>


More information about the llvm-commits mailing list