[PATCH] D54759: [LLD][ELF] Use more specific method to calculate DT_PLTRELSZ

[Peter Smith via Phabricator via llvm-commits]

peter.smith updated this revision to Diff 174889.
peter.smith added a comment.

Thanks very much for the comments. I agree that this is a somewhat niche use case, most likely embedded systems related where someone has built their own loader. I've updated the diff with the following changes:

- The ARM test passed with your updated changes because it was always being skipped! The REQUIRES: ARM should have been REQUIRES: arm. There are a couple of other tests that have that pattern that I'll fix up later today.
- I've simplified the test for the non-Android Arm case in a simpler way (just check the In.RelaIplt name isn't .rel.dyn)
- I've inlined the function and updated the comments in the test as suggested.


https://reviews.llvm.org/D54759

Files:
  ELF/SyntheticSections.cpp
  test/ELF/aarch64-combined-dynrel-ifunc.s
  test/ELF/aarch64-combined-dynrel.s
  test/ELF/arm-combined-dynrel-ifunc.s
  test/ELF/x86-64-combined-dynrel.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54759.174889.patch
Type: text/x-patch
Size: 8178 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181121/5543ebe0/attachment.bin>